Fix/type template data#801
Closed
yhaliaw wants to merge 2 commits into
Closed
Conversation
| Name string `json:"name"` | ||
| Description string `json:"description"` | ||
| Data []byte `json:"data"` | ||
| Data strfmt.Base64 `json:"data"` |
Member
There was a problem hiding this comment.
You can just add:
// swagger:strfmt byte
Data []byte `json:"data"`and
// go:generate go run github.com/go-swagger/go-swagger/cmd/swagger@v0.33.1 generate spec --output=../swagger.yaml --scan-models --work-dir=../../will do the right thing.
Member
There was a problem hiding this comment.
I added the annotations in #800. Will probably split that out and merge separately.
Member
|
Added a PR to hopefully fix this: |
Author
|
Closing this since it is covered by another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix issue #796.
The
byte[]data type for fielddatain the template causes the OpenAPI spec to record it as an array of uint8, when the returned response is a base64-encoded string.This PR uses the
Base64type ofgithub.com/go-openapi/strfmtpackage to ensure the OpenAPI spec generated containsstringas the datatype.I have run
make generateon the code.